fish: Do not overwrite the inherited environment #25173
Closed
+5
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nagisa, thanks for your PR! By analyzing the history of the files in this pull request, we identified @jgillich, @rnhmjoj and @Profpatsch to be potential reviewers. |
nagisa
force-pushed
the
fish-env-overwrite
branch
from
82936d8 to
ee48904
Compare
Mic92
reviewed
Apr 24, 2017
nixos/modules/programs/fish.nix
Outdated
| fenv source ${config.system.build.setEnvironment} > /dev/null ^&1 | ||
| fenv source /etc/fish/foreign-env/shellInit > /dev/null | ||
| if status --is-login | ||
| fenv source ${config.system.build.setEnvironment} > /dev/null ^&1 |
There was a problem hiding this comment.
This could probably break commands in non-interactive ssh sessions:
ssh foobar <command>
In /etc/profile we do instead:
if [ -n "$__ETC_PROFILE_SOURCED" ]; then return; fi
__ETC_PROFILE_SOURCED=1
Something similar is probably preferred in fish.
There was a problem hiding this comment.
Fair point. Updated.
nagisa
force-pushed
the
fish-env-overwrite
branch
from
ee48904 to
99d49b8
Compare
Previously fish would always set up the NixOS environment, shadowing the inherited environment.
This meant that stuff like
nix-shell -p ... --run "fish"
as well as milder variants didn’t work at all.
nagisa
force-pushed
the
fish-env-overwrite
branch
from
99d49b8 to
331de85
Compare
|
There is already #24314 for this. |
|
No activity for a month. Good stuff. |
Janik-Haag
added
the
12. first-time contribution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Previously fish would always set up the NixOS environment, shadowing the inherited environment. This meant that stuff like
as well as milder variants didn’t work at all.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)