Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libidn2: 0.16 -> 2.0.1 #25171

Merged
merged 1 commit into from Apr 26, 2017
Merged

libidn2: 0.16 -> 2.0.1 #25171

merged 1 commit into from Apr 26, 2017

Conversation

lsix
Copy link
Member

@lsix lsix commented Apr 24, 2017

See http://lists.gnu.org/archive/html/info-gnu/2017-04/msg00010.html
for release information. With this release the numbering scheme changed.

Motivation for this change
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@lsix
libidn2: 0.16 -> 2.0.1
0c31837 
See http://lists.gnu.org/archive/html/info-gnu/2017-04/msg00010.html
for release information. With this release the numbering scheme changed.
@mention-bot
Copy link

@lsix, thanks for your PR! By analyzing the history of the files in this pull request, we identified @fpletz to be a potential reviewer.

@vcunat vcunat merged commit 0c31837 into NixOS:master Apr 26, 2017
vcunat added a commit that referenced this pull request Apr 26, 2017
@vcunat
Merge #25171: libidn2: 0.16 -> 2.0.1
d7b21c5 
wget seems to work OK.
@copumpkin
Copy link
Member

Is libidn not a mass rebuild?

@lsix
Copy link
Member Author

lsix commented Apr 26, 2017

@copumpkin libidn is, but libidn2 is not.

From travis log:

[…]
=== Reviewing PR 25171 : libidn2: 0.16 -> 2.0.1
==> Creating nixpkgs repo in /home/travis/.nox/nixpkgs
==> We're in a git repo, trying to fetch it
==> Fetching base (master)
==> Fetching PR
==> Fetching extra history for merging
==> Merging PR into base
Building in /run/user/1000/nox-review-8dfm4d7m: argus asterisk riak-cs libidn2 kiwix stanchion rkt debootstrap asterisk-lts wgetpaste pcsctools wget vogl playonlinux fwknop abcde gitAndTools.git-annex znapzend
these derivations will be built:
[…]

@vcunat
Copy link
Member

vcunat commented Apr 26, 2017

@copumpkin: wget is the only current direct reverse dependency.

@copumpkin
Copy link
Member

@lsix @vcunat oh, I see, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@lsix @mention-bot @copumpkin @vcunat @Mic92