Skip to content

libtiff fix 404 Error on build 4.0.7-5 to 4.0.7-6 #25742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

libtiff fix 404 Error on build 4.0.7-5 to 4.0.7-6 #25742

wants to merge 3 commits into from
+3 −3

Conversation

marcnnn
Copy link
Contributor

@marcnnn marcnnn commented May 12, 2017

Motivation for this change

404 Error on build

Things done

tested using nix-env -i libtiff -f PATH

  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@mention-bot
Copy link

@marcnnn, thanks for your PR! By analyzing the history of the files in this pull request, we identified @vcunat, @edolstra and @grahamc to be potential reviewers.

@marcnnn marcnnn changed the title libtiff fix libtiff fix 404 Error on build 4.0.7-5 to 4.0.7-6 May 12, 2017
vcunat pushed a commit that referenced this pull request May 14, 2017
@vcunat
libtiff: security 4.0.7-5 -> 4.0.7-6 (Debian patches)
1c9ed32 
Taken from PR #25742, only adding extra comment.
vcunat pushed a commit that referenced this pull request May 14, 2017
@vcunat
libtiff: security 4.0.7-5 -> 4.0.7-6 (Debian patches)
557afcc 
Taken from PR #25742, only adding extra comment.

(cherry picked from commit 1c9ed32)
@vcunat
Copy link
Member

vcunat commented May 14, 2017

libtiff: the change is actually a security update fixing several CVEs. I pushed that to staging and release-17.03. Nitpick: the hash-change commit is useless, as it only changes between base16 and base32 representation of the same hash.

cvc4: it would be good to know why the hash has changed. /cc maintainers: @vbgl, @thoughtpolice.

@pSub pSub added 8.has: package (new) This PR adds a new package 8.has: package (update) This PR updates a package to a newer version and removed 8.has: package (new) This PR adds a new package labels May 14, 2017
@vbgl
Copy link
Contributor

vbgl commented May 14, 2017

About cvc4, it seems that the URL is no longer valid. It now redirects to the home page, so the proposed hash is wrong.

There are a few valid URLs (e.g., http://cvc4.cs.stanford.edu/downloads/builds/src/unstable/cvc4-2017-05-14.tar.gz), but I doubt any of them will stay valid long enough.

Maybe the following patch could be OK (briefly tested on MacOS: builds and runs).

diff --git a/pkgs/applications/science/logic/cvc4/default.nix b/pkgs/applications/science/logic/cvc4/default.nix
index 91ee4e4189..20356df6db 100644
--- a/pkgs/applications/science/logic/cvc4/default.nix
+++ b/pkgs/applications/science/logic/cvc4/default.nix
@@ -2,11 +2,11 @@

 stdenv.mkDerivation rec {
   name = "cvc4-${version}";
-  version = "1.5pre-smtcomp2016";
+  version = "1.5pre-20170514";

   src = fetchurl {
-    url = "http://cvc4.cs.nyu.edu/builds/src/cvc4-${version}.tar.gz";
-    sha256 = "15wz0plfc9q8acrwq1ljgsgqmh8pyz5alzv5xpchvv9w76lvj2zf";
+    url = http://cvc4.cs.stanford.edu/downloads/builds/src/unstable/latest-unstable.tar.gz;
+    sha256 = "0d56q7llx78f5mbhx6n4qhbq8c1pjl9a5azx823q7zyj70rmrwlq";
   };

   buildInputs = [ gmp cln pkgconfig readline swig libantlr3c boost jdk autoreconfHook python2 ];

@marcnnn marcnnn closed this May 14, 2017
@Janik-Haag Janik-Haag added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
adrianpk added a commit to adrianpk/nixpkgs that referenced this pull request May 31, 2024
@adrianpk
libtiff: security 4.0.7-5 -> 4.0.7-6 (Debian patches)
1fd123f 
Taken from PR NixOS#25742, only adding extra comment.

(cherry picked from commit 1c9ed32)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (update) This PR updates a package to a newer version 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@marcnnn @mention-bot @vcunat @vbgl @pSub @Janik-Haag