New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] nixos-module: taiga (TaigaIO project management platform) #25744
Conversation
pkgs/top-level/python-packages.nix
Outdated
@@ -145,6 +145,39 @@ in { | |||
|
|||
automat = callPackage ../development/python-modules/automat { }; | |||
|
|||
asana = buildPythonPackage rec { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we do not longer add new expressions here, but in a separate file in python-modules, due the size of this file.
asana = callPackage ../development/python-modules/asana { };
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
last commit should take care of that.
1b113e6
to
e03eb5b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a big PR.
This application requires quite a lot of Python libraries? Do you know whether they update their dependencies regularly? I can imagine this is going to be a pain to maintain. That brings me to the next point: are you going to maintain this taiga as well as its dependencies?
}; | ||
|
||
# ImportError: No module named 'tests' | ||
doCheck = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
checkPhase = ''
py.test
'';
meta = { | ||
homepage = https://code.google.com/p/google-diff-match-patch/; | ||
description = "Diff, Match and Patch libraries for Plain Text"; | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
license?
inherit pname version; | ||
sha256 = "0k1f3v8nbidcmmrk65m7h8v41jqi37653za9fcs96y7jzc8mdflx"; | ||
}; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are tests run? Or does it say that zero tests are found?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes tests are being run here:
Ran 28 tests in 0.280s
sha256 = "00zah4g2h93nbsijz556j97v9qkn9sxcia1a2wrwdwnav2fhzack"; | ||
}; | ||
|
||
doCheck = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
include a comment explaining why you disable the tests
|
||
doCheck = false; | ||
|
||
buildInputs = [ django ]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need for this one
sha256 = "1ks4k0bk4457wfl3xgzr4v7xb0lxmnkhxwhlp0bbnmzipdafw1cl"; | ||
}; | ||
|
||
doCheck = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
include a comment explaining why you disable the tests
rm tests/* | ||
''; | ||
|
||
doCheck = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
include a comment explaining why you disable the tests
sha256 = "05nrydk4a5a99qrxjrcnacs8nbbq5pfjikdpj4w9yn5yfayp057s"; | ||
}; | ||
|
||
doCheck = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
include a comment explaining why you disable the tests
sha256 = "1827i9qcn1ki09i5pg0lmar7cxjv18avh76x1n20947p1cimf3rp"; | ||
}; | ||
|
||
doCheck = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
include a comment explaining why you disable the tests
rm tests/* | ||
''; | ||
|
||
doCheck = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
include a comment explaining why you disable the tests
@FRidh |
@FRidh i just pushed changes to address your notes on doCheck. I hope things are a little more clear now. |
from setuptools import setup, find_packages | ||
|
||
setup( | ||
name = 'taiga-back', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@juanfran another side-request from this nixos-pull-request: can we get a setup.py in taiga-back ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have no problem to include a setup.py inside the taiga-back repo, but we have to be sure that the requirements are managed correctly (currently we manage the requirements in the requirements.txt file) and we don't want to manage it in two places.
added [WIP] cos i just figured out I am pulling in the wrong django-version, and local database setup doesnt quite work |
@@ -58,6 +58,7 @@ | |||
, "smartdc" | |||
, "stylus" | |||
, "svgo" | |||
, { "taiga-events": "https://github.com/betaboon/taiga-events/tarball/4a0b0b1a21d224982b45c0fd84e4353f64ac95a8" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this can go back to mainline as soon as https://github.com/taigaio/taiga-events/pull/30/files is merged
@betaboon is there any interesting in continuing with this PR? |
@aanderse I'm not currently using taiga in any of my projects so i have not real need for it right now. I would be happy if anyone would pick it up tho :) |
@betaboon thanks for the update. I'll close this PR off and as you mentioned if anyone is interested they can pick it up at some point in the future. |
Motivation for this change
I want to run TaigaIO (https://taiga.io/) on my nixos-machine.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandbox
innix.conf
on non-NixOS)
nix-shell -p nox --run "nox-review wip"
./result/bin/
)