Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] nixos-module: taiga (TaigaIO project management platform) #25744

Closed
wants to merge 27 commits into from

Conversation

betaboon
Copy link
Contributor

Motivation for this change

I want to run TaigaIO (https://taiga.io/) on my nixos-machine.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@@ -145,6 +145,39 @@ in {

automat = callPackage ../development/python-modules/automat { };

asana = buildPythonPackage rec {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we do not longer add new expressions here, but in a separate file in python-modules, due the size of this file.

asana = callPackage ../development/python-modules/asana { };

see also: https://github.com/NixOS/nixpkgs/blob/master/doc/languages-frameworks/python.md#contributing-guidelines

Copy link
Contributor Author

@betaboon betaboon May 12, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

last commit should take care of that.

@betaboon betaboon force-pushed the pr-taiga branch 4 times, most recently from 1b113e6 to e03eb5b Compare May 13, 2017 23:38
Copy link
Member

@FRidh FRidh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a big PR.

This application requires quite a lot of Python libraries? Do you know whether they update their dependencies regularly? I can imagine this is going to be a pain to maintain. That brings me to the next point: are you going to maintain this taiga as well as its dependencies?

};

# ImportError: No module named 'tests'
doCheck = false;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checkPhase = ''
  py.test
'';

meta = {
homepage = https://code.google.com/p/google-diff-match-patch/;
description = "Diff, Match and Patch libraries for Plain Text";
};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license?

inherit pname version;
sha256 = "0k1f3v8nbidcmmrk65m7h8v41jqi37653za9fcs96y7jzc8mdflx";
};

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are tests run? Or does it say that zero tests are found?

Copy link
Contributor Author

@betaboon betaboon May 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes tests are being run here:
Ran 28 tests in 0.280s

sha256 = "00zah4g2h93nbsijz556j97v9qkn9sxcia1a2wrwdwnav2fhzack";
};

doCheck = false;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

include a comment explaining why you disable the tests


doCheck = false;

buildInputs = [ django ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need for this one

sha256 = "1ks4k0bk4457wfl3xgzr4v7xb0lxmnkhxwhlp0bbnmzipdafw1cl";
};

doCheck = false;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

include a comment explaining why you disable the tests

rm tests/*
'';

doCheck = false;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

include a comment explaining why you disable the tests

sha256 = "05nrydk4a5a99qrxjrcnacs8nbbq5pfjikdpj4w9yn5yfayp057s";
};

doCheck = false;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

include a comment explaining why you disable the tests

sha256 = "1827i9qcn1ki09i5pg0lmar7cxjv18avh76x1n20947p1cimf3rp";
};

doCheck = false;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

include a comment explaining why you disable the tests

rm tests/*
'';

doCheck = false;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

include a comment explaining why you disable the tests

@betaboon
Copy link
Contributor Author

@FRidh
I guess the taiga-maintainers are updating the dependencies with every minor-update.
As long as I am running taiga-io instances i can maintain this (for every minor taiga-update)

@betaboon
Copy link
Contributor Author

@FRidh i just pushed changes to address your notes on doCheck. I hope things are a little more clear now.

from setuptools import setup, find_packages

setup(
name = 'taiga-back',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@juanfran another side-request from this nixos-pull-request: can we get a setup.py in taiga-back ?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have no problem to include a setup.py inside the taiga-back repo, but we have to be sure that the requirements are managed correctly (currently we manage the requirements in the requirements.txt file) and we don't want to manage it in two places.

@betaboon betaboon changed the title nixos-module: taiga (TaigaIO project management platform) [WIP] nixos-module: taiga (TaigaIO project management platform) May 16, 2017
@betaboon
Copy link
Contributor Author

added [WIP] cos i just figured out I am pulling in the wrong django-version, and local database setup doesnt quite work

@@ -58,6 +58,7 @@
, "smartdc"
, "stylus"
, "svgo"
, { "taiga-events": "https://github.com/betaboon/taiga-events/tarball/4a0b0b1a21d224982b45c0fd84e4353f64ac95a8" }
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can go back to mainline as soon as https://github.com/taigaio/taiga-events/pull/30/files is merged

@aanderse
Copy link
Member

@betaboon is there any interesting in continuing with this PR?

@betaboon
Copy link
Contributor Author

@aanderse I'm not currently using taiga in any of my projects so i have not real need for it right now.
considering the age of this PR, the fact that is has been the very first nixos-module that i implemented and the bit-rot i would guess it needs (quite) some work.

I would be happy if anyone would pick it up tho :)

@aanderse
Copy link
Member

@betaboon thanks for the update. I'll close this PR off and as you mentioned if anyone is interested they can pick it up at some point in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants