lib platform parsing: Fix windows support to conform to LLVM #25275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Ericson2314, thanks for your PR! By analyzing the history of the files in this pull request, we identified @nbp, @edolstra and @rbvermaa to be potential reviewers. |
Ericson2314
added
the
6.topic: cross-compilation
Ericson2314
force-pushed
the
platform-normalize
branch
2 times, most recently
from
c15ecf7
to
475b65c
Compare
There is no more `cygwin` OS, but instead a `cygnus` abi. "win32" and "mingw32" parse as `windows`. Add a 3-part hack because autotools breaks on explicit abi with windows-like (e.g. "i686-pc-windows-gnu"). Also change cross triples to conform
Ericson2314
force-pushed
the
platform-normalize
branch
from
475b65c
to
fcde869
Compare
Actually the old check wasn't being hit because a slightly different target triple was being used.
|
No regressions, and fairly boring PR, so merging. |
|
This broke tests: http://hydra.nixos.org/build/52055698 |
|
Oof sorry I thought I tested everything! Unfortunately I'm now on vacation sans laptop too. That test means the definition of |
Ericson2314
added a commit
to Ericson2314/nixpkgs
that referenced
this pull request
May 17, 2017
Second attempt at pull request NixOS#25275 This reverts commit b70924b, reapplying 2282a57
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This gives us a decent story on mingw and cygwin.
CC @taktoa
Things done
http://hydra.nixos.org/eval/1353847