grsecurity: add support for proprietary nvidia video driver #25276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@thineye, thanks for your PR! By analyzing the history of the files in this pull request, we identified @joachifm, @thoughtpolice and @abbradar to be potential reviewers. |
|
See also #25277 |
joachifm
reviewed
Apr 27, 2017
| @@ -59,7 +59,12 @@ let | |||
| ] | |||
| else [ (fetchurl { | |||
| url = https://git.archlinux.org/svntogit/packages.git/plain/trunk/kernel_4.10.patch?h=packages/nvidia; sha256 = "0zhpx3baq2pca2pmz1af5cp2nzjxjx0j9w5xrdy204mnv3v2708z"; | |||
| }) ]; | |||
| }) | |||
| (optional (kernel.features.grsecurity or false) (fetchurl { | |||
There was a problem hiding this comment.
optional expands to a singleton list so you'd ideally append it to the patches list; as it is, it creates a list-of-lists.
|
|
||
|
|
||
| # Grsecurity kernel for proprietary nvidia driver | ||
| linux_grsec_nvidia = linux_grsec_nixos.override (old: { |
There was a problem hiding this comment.
I believe this mixes override and overrideAttrs; the former affects the parameters passed to the original expression; the latter affects the inner mkDerivation call. With override you typically pass a plain record parameter.
ghost
closed this
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Nixos currently lacks off combatibility between the grsecurity enabled linux kernel and the proprietary nvidia video driver.
Two main changes were needed:
Both changes affects only if the combination grsecurity kernel + proprietary nvidia is in use.
Tests are done on my main desktop computer with and without sandboxing (state: channel 17.03-small and channel unstable).
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)