ssh: Add Newline to KnownHostsText #25818
Conversation
SSH expects a new line at the end of known_hosts file. Without a new line the next entry goes on the same line as the last entry in known_hosts causing errors.
|
@jammerful, thanks for your PR! By analyzing the history of the files in this pull request, we identified @falsifian, @edolstra and @bluescreen303 to be potential reviewers. |
|
The Travis error was: For some reason, the script decided to build a lot of stuff. Excerpt from the log: and so on. I don't see how |
|
Thanks! |
|
Hydra has queued >8k jobs on master, even before this PR. It's not Travis that's broken but our workflow of merging larger rebuilds to master directly. |
| (h: assert h.hostNames != []; | ||
| concatStringsSep "," h.hostNames + " " | ||
| + (if h.publicKey != null then h.publicKey else readFile h.publicKeyFile) | ||
| ); | ||
| )) + "\n"; |
There was a problem hiding this comment.
Instead of using both concatMapStringSep and adding a \n at the end, it would be simpler to just add a \n in the inner loop.
Motivation for this change
SSH expects a new line at the end of known_hosts file.
Without a new line the next new entry goes on the same line
as the last entry in known_hosts causing errors.
For example:
example1.com blahblahexample2.com blahblah
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"