Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eventstore 3.5.0 -> 3.9.4 #25816

Closed
wants to merge 1 commit into from
Closed

eventstore 3.5.0 -> 3.9.4 #25816

wants to merge 1 commit into from

Conversation

paullucas
Copy link

@paullucas paullucas commented May 16, 2017 •
edited

Motivation for this change

Need a more current version of EventStore (3.5.0 is outdated).

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@paullucas, thanks for your PR! By analyzing the history of the files in this pull request, we identified @puffnfresh, @rht and @ericsagnes to be potential reviewers.

@paullucas
Copy link
Author

It seems to be working, but I did notice errors from the build.sh script. This is why I added git as a dependency (which may not have been necessary). Are the following errors expected?

Build succeeded.
	 0 Warning(s)
	 0 Error(s)

Time Elapsed 00:00:08.9089820
./build.sh: line 95: git: command not found
Reverted ./etc/EventStore.Rags.Tests/Properties/AssemblyInfo.cs
./build.sh: line 95: git: command not found
Reverted ./etc/EventStore.Documentation/Properties/AssemblyInfo.cs
./build.sh: line 95: git: command not found
Reverted ./etc/EventStore.UpgradeProjections/Properties/AssemblyInfo.cs
./build.sh: line 95: git: command not found
Reverted ./src/EventStore.Padmin/Properties/AssemblyInfo.cs
./build.sh: line 95: git: command not found
Reverted ./src/EventStore.ClientAPI/Properties/AssemblyInfo.cs
./build.sh: line 95: git: command not found
Reverted ./src/EventStore.Projections.Core.Tests/Properties/AssemblyInfo.cs
./build.sh: line 95: git: command not found
Reverted ./src/EventStore.Transport.Http/Properties/AssemblyInfo.cs
./build.sh: line 95: git: command not found
Reverted ./src/EventStore.TestClient/Properties/AssemblyInfo.cs
./build.sh: line 95: git: command not found
Reverted ./src/EventStore.ClusterNode.Web/Properties/AssemblyInfo.cs
./build.sh: line 95: git: command not found
Reverted ./src/EventStore.Common/Properties/AssemblyInfo.cs
./build.sh: line 95: git: command not found
Reverted ./src/EventStore.Core/Properties/AssemblyInfo.cs
./build.sh: line 95: git: command not found
Reverted ./src/EventStore.BufferManagement.Tests/Properties/AssemblyInfo.cs
./build.sh: line 95: git: command not found
Reverted ./src/esquery/Properties/AssemblyInfo.cs
./build.sh: line 95: git: command not found
Reverted ./src/EventStore.ClusterNode/Properties/AssemblyInfo.cs
./build.sh: line 95: git: command not found
Reverted ./src/EventStore.Transport.Tcp/Properties/AssemblyInfo.cs
./build.sh: line 95: git: command not found
Reverted ./src/EventStore.Core.Tests/Properties/AssemblyInfo.cs
./build.sh: line 95: git: command not found
Reverted ./src/EventStore.Projections.Core/Properties/AssemblyInfo.cs
./build.sh: line 95: git: command not found
Reverted ./src/EventStore.ClientAPI.Embedded/Properties/AssemblyInfo.cs
./build.sh: line 95: git: command not found
Reverted ./src/EventStore.BufferManagement/Properties/AssemblyInfo.cs
./build.sh: line 105: git: command not found
Reverted ./src/EventStore.Common/Utils/VersionInfo.cs

@FRidh
Copy link
Member

FRidh commented May 16, 2017

just adding git as function parameter won't add it to the buildInputs and thus won't solve the issue you report.

@paullucas
Copy link
Author

Thanks! I've now added Git to buildInputs. New error message:

Build succeeded.
	 0 Warning(s)
	 0 Error(s)

Time Elapsed 00:00:10.2000840
fatal: Not a git repository (or any of the parent directories): .git
Reverted ./etc/EventStore.Rags.Tests/Properties/AssemblyInfo.cs
fatal: Not a git repository (or any of the parent directories): .git
Reverted ./etc/EventStore.Documentation/Properties/AssemblyInfo.cs
fatal: Not a git repository (or any of the parent directories): .git
Reverted ./etc/EventStore.UpgradeProjections/Properties/AssemblyInfo.cs
fatal: Not a git repository (or any of the parent directories): .git
Reverted ./src/EventStore.Padmin/Properties/AssemblyInfo.cs
fatal: Not a git repository (or any of the parent directories): .git
Reverted ./src/EventStore.ClientAPI/Properties/AssemblyInfo.cs
fatal: Not a git repository (or any of the parent directories): .git
Reverted ./src/EventStore.Projections.Core.Tests/Properties/AssemblyInfo.cs
fatal: Not a git repository (or any of the parent directories): .git
Reverted ./src/EventStore.Transport.Http/Properties/AssemblyInfo.cs
fatal: Not a git repository (or any of the parent directories): .git
Reverted ./src/EventStore.TestClient/Properties/AssemblyInfo.cs
fatal: Not a git repository (or any of the parent directories): .git
Reverted ./src/EventStore.ClusterNode.Web/Properties/AssemblyInfo.cs
fatal: Not a git repository (or any of the parent directories): .git
Reverted ./src/EventStore.Common/Properties/AssemblyInfo.cs
fatal: Not a git repository (or any of the parent directories): .git
Reverted ./src/EventStore.Core/Properties/AssemblyInfo.cs
fatal: Not a git repository (or any of the parent directories): .git
Reverted ./src/EventStore.BufferManagement.Tests/Properties/AssemblyInfo.cs
fatal: Not a git repository (or any of the parent directories): .git
Reverted ./src/esquery/Properties/AssemblyInfo.cs
fatal: Not a git repository (or any of the parent directories): .git
Reverted ./src/EventStore.ClusterNode/Properties/AssemblyInfo.cs
fatal: Not a git repository (or any of the parent directories): .git
Reverted ./src/EventStore.Transport.Tcp/Properties/AssemblyInfo.cs
fatal: Not a git repository (or any of the parent directories): .git
Reverted ./src/EventStore.Core.Tests/Properties/AssemblyInfo.cs
fatal: Not a git repository (or any of the parent directories): .git
Reverted ./src/EventStore.Projections.Core/Properties/AssemblyInfo.cs
fatal: Not a git repository (or any of the parent directories): .git
Reverted ./src/EventStore.ClientAPI.Embedded/Properties/AssemblyInfo.cs
fatal: Not a git repository (or any of the parent directories): .git
Reverted ./src/EventStore.BufferManagement/Properties/AssemblyInfo.cs
fatal: Not a git repository (or any of the parent directories): .git
Reverted ./src/EventStore.Common/Utils/VersionInfo.cs

@paullucas
Copy link
Author

@puffnfresh: Any ideas as to what's happening with the build.sh script?

@a4d442663580
Copy link

(@paullucas, the err is because fetchFromGithub afterward strips the repo (.git, ...) to make it deterministic (see

nixpkgs/pkgs/build-support/fetchgit/nix-prefetch-git

Line 237 in afec912

make_deterministic_repo(){
) yet on the other hand build.sh depends on the git-related files)

@paullucas
Copy link
Author

paullucas commented Jul 19, 2017 •
edited

I've been using this locally for weeks now and haven't had any problems. If anyone is able to help with testing on MacOS / Linux, it should be good to go.

@FRidh
Copy link
Member

FRidh commented Jul 20, 2017

@paullucas judging from the build.sh and this commit the script tries to extract some info with git and update the VersionInfo.cs file. I have no idea whether it is relevant.

Because this patching is not working since we remove .git, and because you say the package works fine, I suggest you remove git again from the parameters and buildInputs and just leave a note referring to this comment.

@paullucas paullucas closed this Nov 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
2.status: work-in-progress 8.has: package (update) 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@paullucas @mention-bot @FRidh @a4d442663580 @joachifm @Janik-Haag