opencv: Fix OpenCV build on non NixOS platform #25814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sifmelcara, thanks for your PR! By analyzing the history of the files in this pull request, we identified @abbradar, @basvandijk and @cpages to be potential reviewers. |
OpenCV's CMakeFile will use libraries in /lib and /lib64 if it can find libraries from those paths. However, it causes build failure because nix detects impure paths being used.
sifmelcara
force-pushed
the
fix/opencvCMakeLibraryPath
branch
from
6002d9c
to
b496ffb
Compare
sifmelcara
changed the title
|
Why does this fix build errors on non-NixOS systems? |
|
Arch Linux have something like Because cmake tries to use those impure libraries, ld reports |
|
@sifmelcara makes sense. You have my thumbs up. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Fixes #21994
I solve this issue by deleting this paragraph
To reproduce this issue, a distro which have libraries symlinked in
/liband/lib64is needed. (i.e Arch Linux)Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)Edit: I forgot to put opencv in title, now fixed.