Compiler: fixed VirtualMetaclassType#metaclass #4375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add a spec for: Class.class.is_a?(Class)
Class.class.is_a?(Class.class) |
|
I think that is unnecessary. |
|
@rockwyc992 ...with emphasis on "should be" - the spec is almost written right there ;-) |
fixed crystal-lang#4374 VirtualMetaclassType#metaclass will use super(Type)#metaclass but it should override this method like what MetaclassType#metaclass do.
MetaclassType#metaclass has already implement that.
rockwyc992
force-pushed
the
fix/compiler/VirtualMetaclassType_metaclass
branch
from
847d8ed
to
34415f9
Compare
|
I rebased this PR to resolve the conflict in spec. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #4374
VirtualMetaclassType#metaclasswill usesuper, find inType#metaclass,but it should override this method like what
MetaclassType#metaclassdoes.