Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kdeApplications.ktnef: init at 17.04.0 #25697

Closed
wants to merge 5 commits into from
Closed

Conversation

peterhoeg
Copy link
Member

Motivation for this change

I actually needed the KDE tnef VIEWER while this is the tnef LIBRARY which was pretty stupid of me...

ktnef (the viewer) is part if kdepim it seems.

@ttuegel: is this the proper way to package kdeApplication components?

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@peterhoeg, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ttuegel, @orivej and @FRidh to be potential reviewers.

@ttuegel
Copy link
Member

ttuegel commented May 11, 2017

The viewer is part of KMail, which I have packaged in this branch.

@orivej
Copy link
Contributor

orivej commented May 11, 2017

That's great! Would you also package akregator, or should I add it myself and send you a pull request (if kde-applications branch is not merged here yet)?

@ttuegel
Copy link
Member

ttuegel commented May 11, 2017

@orivej I am just adding some source patches to complete the work @vandenoever started in #20576, so Akregator and the rest of the KDE PIM suite will be packaged after I cherry-pick the rest of those patches. I plan to merge that branch rather soon because it contains some important changes to the way Qt/KDE applications are packaged.

@peterhoeg
Copy link
Member Author

Got it, closing this in favour of your work.

@peterhoeg peterhoeg closed this May 11, 2017
@peterhoeg peterhoeg deleted the p/ktnef branch May 11, 2017 13:59
@peterhoeg peterhoeg restored the p/ktnef branch May 12, 2017 01:09
@peterhoeg peterhoeg deleted the p/ktnef branch May 14, 2017 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants