Skip to content

xen service: Fix removing netfilter rules while stopping xen-bridge #25700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2017

Conversation

michalpalka
Copy link

This fixes a bug in the stopping script for the xen-bridge service,
which caused the script to crash and fail to remove some
netfilter rules.

Motivation for this change

Currently, stopping the xen-bridge service results in the following error messages being logged by systemd, and two netfilter rules not being removed.

May 11 08:14:27 nixos systemd[1]: xen-bridge.service: Control process exited, code=exited status=1
May 11 08:14:27 nixos systemd[1]: Stopped Xen bridge.
May 11 08:14:27 nixos systemd[1]: xen-bridge.service: Unit entered failed state.
May 11 08:14:27 nixos systemd[1]: xen-bridge.service: Failed with result 'exit-code'.

This pull request corrects the commands that remove the netfilter rules.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

This fixes a bug in the stopping script for the xen-bridge service,
which caused the script to crash and fail to remove some
netfilter rules.
@mention-bot
Copy link

@michalpalka, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edolstra, @oxij and @peti to be potential reviewers.

@michalpalka
Copy link
Author

@joachifm

@joachifm joachifm merged commit 8f89e43 into NixOS:master May 21, 2017
@michalpalka michalpalka deleted the xen-bridge-stop-fix branch June 9, 2017 20:38
@SigmaSquadron SigmaSquadron added the 6.topic: xen-project The Xen Project hypervisor label Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: xen-project The Xen Project hypervisor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants