amqptools: init #25317
Closed
amqptools: init #25317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please add a version string of some sort to the name. I notice this hasn't been updated since 2012 and has no proper release. Does that mean the software is "complete"? |
|
This pull request might have been a bit premature. Although the software works and is "complete", similar tools are included in the rabbitmq-c package, and that is actually maintained. So I don't think this should be merged, after all. @joachifm, thanks for your feedback, and sorry for wasting your time. I'll try to make the next pull request a bit more useful. |
|
@apeschar no problem :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Add amqptools package. It's useful for testing servers such as RabbitMQ.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)