Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

geogebra: 5-0-350-0 -> 5-0-355-0 #25324

Merged
merged 1 commit into from Apr 29, 2017
Merged

geogebra: 5-0-350-0 -> 5-0-355-0 #25324

merged 1 commit into from Apr 29, 2017

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Apr 29, 2017 •
edited

Motivation for this change

GeoGebra has published some new updates, so we need an update to ensure that the package won't break in the next days/weeks when another release comes out and 5-0-350-0 will be removed from the download server.

See here for more information: http://download.geogebra.org/installers/5.0/

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@Ma27, thanks for your PR! By analyzing the history of the files in this pull request, we identified @obadz and @moyamo to be potential reviewers.

@obadz obadz merged commit b12f76d into NixOS:master Apr 29, 2017
@Ma27 Ma27 deleted the update/geogebra branch April 29, 2017 14:26
joachifm pushed a commit that referenced this pull request Jun 27, 2017
@Ma27 @joachifm
geogebra: 5-0-350-0 -> 5-0-355-0 (#25324)
8e4eb89 
(cherry picked from commit b12f76d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ma27 @mention-bot @obadz