Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix 'command-not-found: is a directory' error #25310

Merged
merged 1 commit into from Apr 29, 2017

Conversation

jerith666
Copy link
Contributor

Motivation for this change

5a5db60 from #24962 caused this issue by changing the way that command-not-found is invoked.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@jerith666, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edolstra, @makefu and @spwhitt to be potential reviewers.

@jerith666
Copy link
Contributor Author

also cc @Mic92 as a potential reviewer.

@makefu
Copy link
Contributor

makefu commented Apr 29, 2017

@jerith666 i approve of this PR

@Mic92 Mic92 merged commit ffdc1b0 into NixOS:master Apr 29, 2017
@Mic92
Copy link
Member

Mic92 commented Apr 29, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants