glfw: fix the install name id on darwin #25308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@acowley, thanks for your PR! By analyzing the history of the files in this pull request, we identified @andrewrk, @wkennington and @matthewbauer to be potential reviewers. |
LnL7
reviewed
Apr 30, 2017
| @@ -23,7 +23,11 @@ stdenv.mkDerivation rec { | |||
|
|
|||
| cmakeFlags = "-DBUILD_SHARED_LIBS=ON"; | |||
|
|
|||
| meta = with stdenv.lib; { | |||
| postInstall = stdenv.lib.optionalString stdenv.isDarwin '' | |||
| install_name_tool -id $out/lib/libglfw.3.2.dylib $out/lib/libglfw.3.2.dylib | |||
There was a problem hiding this comment.
You should be able to use the fixDarwinDylibNames setup hook for this.
|
This should probably also have |
Also change platforms to ‘unix‘.
|
@LnL7 Thanks for the suggestions! I have made the changes you described. |
LnL7
approved these changes
May 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
I encountered a runtime dynamic link failure without this change.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)