Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nvidia-x11: switch download urls to https #25333

Merged
merged 1 commit into from Apr 30, 2017

Conversation

zraexy
Copy link
Member

@zraexy zraexy commented Apr 29, 2017

Motivation for this change

download.nvidia.com no longer supports FTP but now also supports HTTPS
Fixes #25326

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@zraexy, thanks for your PR! By analyzing the history of the files in this pull request, we identified @vcunat, @abbradar and @aske to be potential reviewers.

@timsears
Copy link

This change by nvidia also breaks installs of 17.03, and maybe other stable versions, that require nvidia drivers.

@7c6f434c 7c6f434c merged commit b5c3586 into NixOS:master Apr 30, 2017
vcunat pushed a commit that referenced this pull request Apr 30, 2017
nvidia-x11: switch download urls to https
(cherry picked from commit b5c3586)
@vcunat
Copy link
Member

vcunat commented Apr 30, 2017

Right, picked to 17.03.

@rongcuid
Copy link
Contributor

17.03 still seems to be broken by this.

@rongcuid
Copy link
Contributor

Just confirmed 17.03-small's fix works. All right.

@vcunat
Copy link
Member

vcunat commented May 1, 2017

It takes some time for channels to update. You can find explanation on http://howoldis.herokuapp.com/

@zraexy zraexy deleted the zraexy-nvidia-x11 branch May 5, 2017 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants