cmake: Prevent it from searching for packages in / when cross-compiling for Windows #25319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DavidEGrayson, thanks for your PR! By analyzing the history of the files in this pull request, we identified @7c6f434c, @abbradar and @dtzWill to be potential reviewers. |
|
I wonder if it is enough of a rebuild to target into staging… GTK2, GTK3, Qt5, Qt4 all depend on CMake, for example. |
|
I think this should go into staging. |
|
Thank you for taking a look. The new pull request is ready: #25330 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
I was using the CMake from nixpkgs in my own project (outside of nixpkgs) to cross-compile some software for Windows. That software uses the
find_packagecommand to find Qt5Widgets. CMake was finding the Qt5Widgets package on my build system and trying (unsuccessfully) to use it. Obviously, that goes against the whole point of purity in Nix. This pull request adds a patch that comments out a line that adds/to theCMAKE_SYSTEM_PREFIX_PATH. Thanks!Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)