Skip to content

csound: add liblo to buildinputs to enable osc capabilities #25458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2017

Conversation

seppeljordan
Copy link
Contributor

Motivation for this change

We probably wanna have OSC support in csound on nixos, this will enable it.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature. The key has expired.
erictapen Kerstin
@mention-bot
Copy link

@seppeljordan, thanks for your PR! By analyzing the history of the files in this pull request, we identified @hlolli, @MarcWeber and @wkennington to be potential reviewers.

@seppeljordan
Copy link
Contributor Author

Why does this not get merged? Could someone provide feedback? Thanks.

@hlolli
Copy link
Member

hlolli commented May 15, 2017

Green light from me, this patch is needed.

@joachifm joachifm merged commit c1894be into NixOS:master May 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants