icdiff: 1.7.3 -> 1.9.0 #25847
Merged
icdiff: 1.7.3 -> 1.9.0 #25847
+6
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
reviewed
May 17, 2017
pkgs/tools/text/icdiff/default.nix
Outdated
| @@ -2,13 +2,13 @@ | |||
|
|
|||
| buildPythonApplication rec { | |||
There was a problem hiding this comment.
This should be also moved out of pythonPackages to all-packages. It is not a python library therefor does not needs to be build against different versions of python.
Also move to all-packages.nix, because it is an application and not a library.
aneeshusa
force-pushed
the
update-icdiff-to-1.9.0
branch
from
58e58e4 to
e75297a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Changelog for 1.9.0. is at https://github.com/jeffkaufman/icdiff/blob/66998d8b3e8d2ea44b6caf55627de58bc9ffe4c3/ChangeLog.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)