mikutter: new package #25852
Closed
mikutter: new package #25852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
midchildan
force-pushed
the
mikutter
branch
3 times, most recently
from
d54aecb to
2abdf82
Compare
|
Two things:
1 - Put every logical change in a separate commit. As I have noted, you
modified pthread-stubs too; it deserves a commit for himself alone
2 - The format for new packages/expressions is "<name of software>: init at
<version>", and for updates is "<name of software>: <old version> -> <new
version>".
2017-05-17 7:11 GMT-03:00 midchildan <notifications@github.com>:
… Motivation for this change Things done
- Tested using sandboxing
(nix.useSandbox
<http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox> on
NixOS,
or option build-use-sandbox in nix.conf
<http://nixos.org/nix/manual/#sec-conf-file>
on non-NixOS)
- Built on platform(s)
- NixOS
- macOS
- Linux
- Tested compilation of all pkgs that depend on this change using nix-shell
-p nox --run "nox-review wip"
- Tested execution of all binary files (usually in ./result/bin/)
- Fits CONTRIBUTING.md
<https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md>.
------------------------------
------------------------------
You can view, comment on, or merge this pull request online at:
#25852
Commit Summary
- mikutter: new package
File Changes
- *A* pkgs/applications/networking/instant-messengers/mikutter/Gemfile
<https://github.com/NixOS/nixpkgs/pull/25852/files#diff-0> (37)
- *A* pkgs/applications/networking/instant-messengers/mikutter/
Gemfile.lock <https://github.com/NixOS/nixpkgs/pull/25852/files#diff-1>
(104)
- *A* pkgs/applications/networking/instant-messengers/mikutter/
core/plugin/gtk/Gemfile
<https://github.com/NixOS/nixpkgs/pull/25852/files#diff-2> (3)
- *A* pkgs/applications/networking/instant-messengers/mikutter/
core/plugin/image_file_cache/Gemfile
<https://github.com/NixOS/nixpkgs/pull/25852/files#diff-3> (1)
- *A* pkgs/applications/networking/instant-messengers/mikutter/
core/plugin/photo_support/Gemfile
<https://github.com/NixOS/nixpkgs/pull/25852/files#diff-4> (5)
- *A* pkgs/applications/networking/instant-messengers/mikutter/
core/plugin/uitranslator/Gemfile
<https://github.com/NixOS/nixpkgs/pull/25852/files#diff-5> (5)
- *A* pkgs/applications/networking/instant-messengers/mikutter/
default.nix <https://github.com/NixOS/nixpkgs/pull/25852/files#diff-6>
(59)
- *A* pkgs/applications/networking/instant-messengers/mikutter/
gemset.nix <https://github.com/NixOS/nixpkgs/pull/25852/files#diff-7>
(365)
- *A* pkgs/applications/networking/instant-messengers/mikutter/
shell.nix <https://github.com/NixOS/nixpkgs/pull/25852/files#diff-8>
(26)
- *A* pkgs/development/libraries/pthread-stubs/default.nix
<https://github.com/NixOS/nixpkgs/pull/25852/files#diff-9> (17)
- *M* pkgs/top-level/all-packages.nix
<https://github.com/NixOS/nixpkgs/pull/25852/files#diff-10> (7)
Patch Links:
- https://github.com/NixOS/nixpkgs/pull/25852.patch
- https://github.com/NixOS/nixpkgs/pull/25852.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#25852>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFrc9nuuskMU4DmdA9177i3F0_we-jR2ks5r6sfegaJpZM4NdptO>
.
|
|
Thanks. I have updated the commits. |
|
mikutter wasn't working well in a test environment, so I pushed a little fix that sets |
Mic92
reviewed
May 20, 2017
| {stdenv, fetchurl}: | ||
|
|
||
| stdenv.mkDerivation rec { | ||
| name = "pthread-stubs-${version}"; |
There was a problem hiding this comment.
we already have this package in pkgs/servers/x11/xorg/default.nix. It is reachable via xlibs.libpthreadstubs
Mic92
reviewed
May 20, 2017
| # hack wrapGAppsHook wants a file not a symlink | ||
| mv $out/mikutter.rb $out/bin/mikutter | ||
|
|
||
| gappsWrapperArgs+=( |
There was a problem hiding this comment.
Using wrapGAppsHook is always a good idea, as it fixes a number of other things.
Mic92
reviewed
May 20, 2017
| @@ -0,0 +1,37 @@ | |||
| alias __source_distinct__ source | |||
There was a problem hiding this comment.
That file would be smaller if mikutter would had a gemspec. Than something like ./pkgs/tools/security/metasploit would be possible.
There was a problem hiding this comment.
Unfortunately, mikutter doesn't provide one.
Mic92
reviewed
May 20, 2017
| gtk2 | ||
| xorg.libXdmcp | ||
| pcre | ||
| pthread_stubs |
There was a problem hiding this comment.
I think this file needs to be revisited now, as I have removed pthread_stubs.
Mic92
reviewed
May 20, 2017
| description = "An extensible Twitter client"; | ||
| homepage = "https://mikutter.hachune.net"; | ||
| platforms = ruby.meta.platforms; | ||
| license = licenses.mit; |
There was a problem hiding this comment.
Do you want to maintain this package?
There was a problem hiding this comment.
Then please add yourself as described here: https://github.com/nixos-users/wiki/wiki/Get-Involved#becoming-a-nixpkgs-maintainer
Janik-Haag
added
the
12. first-time contribution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
mikutter is an extensible Twitter client.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)