rdkafka: fixes darwin build #25839
Merged
rdkafka: fixes darwin build #25839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without --disable-ssl librdkafka ./configure detects that OpenSSL is installed but when it tries to link it fails because the default version is incompatible (1.0.2 vs required 1.1.x). confluentinc/librdkafka#49 (comment)
|
@czyzykowski, thanks for your PR! By analyzing the history of the files in this pull request, we identified @utdemir, @Boothead and @wkennington to be potential reviewers. |
LnL7
approved these changes
May 16, 2017
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Fixes build on macOS. It was failing because the
./configurewas erroneously detecting incompatible SSL library. Disabling it during that step means that the library can be successfully build. The lack of SSL support is the same as the default for Linux.Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)