nbstripout: fix build on darwin #25851
Merged
+7
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Don't merge yet. I need to work on this a little bit more. |
jluttine
force-pushed
the
fix-nbstripout-on-darwin
branch
2 times, most recently
from
81f9bdb to
f2ca64b
Compare
jluttine
force-pushed
the
fix-nbstripout-on-darwin
branch
from
f2ca64b to
378b365
Compare
jluttine
force-pushed
the
fix-nbstripout-on-darwin
branch
from
378b365 to
4a9acbb
Compare
|
Now this should be good to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Build fails on darwin because, for some reason,
echo -nisn't handled properly: https://hydra.nixos.org/build/52896770/nixlog/14I patched the failing test on darwin to use
\cat the end of the string instead of-nflag.Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)