Skip to content

buildbot: 0.9.6 -> 0.9.7 #25738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 14, 2017
Merged

buildbot: 0.9.6 -> 0.9.7 #25738

merged 1 commit into from
May 14, 2017

Conversation

nand0p
Copy link
Contributor

@nand0p nand0p commented May 12, 2017

Tested on NixOS

@mention-bot
Copy link

@nand0p, thanks for your PR! By analyzing the history of the files in this pull request, we identified @copumpkin and @lsix to be potential reviewers.

@lsix
Copy link
Member

lsix commented May 12, 2017

Hi,

I do not see the version update from 0.9.6 to 0.9.7 in pkgs/development/tools/build-managers/buildbot/default.nix, only the sha256 update. Did you forget to commit it?

There is this also a note in pkgs/development/tools/build-managers/buildbot/default.nix:

      # Remove this line after next update. See
      # https://github.com/buildbot/buildbot/commit/e7fc8c8eba903c2aa6d7e6393499e5b9bffc2334
      rm -fv buildbot/test/unit/test_mq_wamp.py

Have you tried re-enabeling this test?

@pSub pSub added the 8.has: package (update) This PR updates a package to a newer version label May 12, 2017

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
@nand0p
Copy link
Contributor Author

nand0p commented May 12, 2017

@lsix updated patching and version.

@copumpkin There is still the issue with buildbot daemon mode not working, which appears to be due to PYTHONPATH. I'm not entirely sure how to fix this, but it started happening with ca5a1d9 and/or 49b20e5

this is the error:
/nix/store/6lyqi13na3l72b7x66sdgc3bl814niwl-wrapped-buildbot-0.9.7/bin/buildbot start /tmp/002 Following twistd.log until startup finished.. The buildmaster took more than 10 seconds to start, so we were unable to confirm that it started correctly. Please 'tail twistd.log' and look for a line that says 'BuildMaster is running' to verify correct startup.

@FRidh FRidh merged commit a9238ea into NixOS:master May 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (update) This PR updates a package to a newer version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants