pythonPackages.ablog: init at 0.8.4 #25732
Conversation
added also the necessary package pythonPackages.invoke: init at 0.17.0
|
@massimo-zaniboni, thanks for your PR! By analyzing the history of the files in this pull request, we identified @FRidh to be a potential reviewer. |
|
Please read the header of the file you modified. |
|
|
||
| propagatedBuildInputs = with self; [ sphinx alabaster invoke dateutil werkzeug ]; | ||
|
|
||
| src = pkgs.fetchurl { |
| meta = { | ||
| description = "A Sphinx extension that converts any documentation or personal website project into a full-fledged blog."; | ||
| license = licenses.mit; | ||
| homepage = http://ablog.readthedocs.org/; |
There was a problem hiding this comment.
are you going to maintain this package?
|
About travis error: I will fix the merge request within few days, applying this time all the necessary test commands, as listed in the error messages. So I hope to be 100% correct the next time. Sorry! BTW I followed the instructions on http://nixos.org/nixpkgs/manual/#chap-submitting-changes but they are not in par with what I understood here/now. Maybe I will try to update the manual too. |
ABlog is an application / Python cli tool so (if I understood correctly) I need to move away from this module that contains only libraries, and build with BTW as partial excuse, in this module there is also Sphinx, from which ABlog is derived, and so I considered (faulty) as the right place. Sorry. I will update within few days, and I will integrate also the other change requests. |
|
@FRidh I decided to abort the PR because I will not use ABlog in production, and probably this PR is not useful to others. Many thanks for the review, and sorry for the waste of time. In any case I understood better something about Nix. |
added also the necessary package
pythonPackages.invoke: init at 0.17.0
Motivation for this change
I need to use the package in production, so I added and tested it.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)