dosfstools: fix build on darwin #25740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@georgewhewell, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edolstra, @dezgeg and @obadz to be potential reviewers. |
LnL7
suggested changes
May 12, 2017
| @@ -11,14 +11,14 @@ stdenv.mkDerivation rec { | |||
| sha256 = "1a2zn1655d5f1m6jp9vpn3bp8yfxhcmxx3mx23ai9hmxiydiykr1"; | |||
| }; | |||
|
|
|||
| nativeBuildInputs = [ autoreconfHook pkgconfig ]; | |||
| nativeBuildInputs = [ autoreconfHook pkgconfig libiconv ]; | |||
There was a problem hiding this comment.
this should be conditional for darwin, eg.
{
nativeBuildInputs = [ autoreconfHook pkgconfig ]
++ stdenv.lib.optional stdenv.isDarwin libiconv;
}
georgewhewell
force-pushed
the
dosfstools/fix-darwin
branch
from
dac0343
to
867e7f4
Compare
|
@LnL7 thanks, have updated |
LnL7
approved these changes
May 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
before:
charconv.c:2:10: fatal error: 'iconv.h' file not foundafter: build works
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)