openal-soft: move cmake to nativeBuildInputs #25416
Merged
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows cross-compiling it.
|
@lheckemann, thanks for your PR! By analyzing the history of the files in this pull request, we identified @dezgeg, @matthewbauer and @ftrvxmtrx to be potential reviewers. |
Mic92
reviewed
May 1, 2017
| buildInputs = [ cmake ] | ||
| nativeBuildInputs = [ cmake ]; | ||
|
|
||
| buildInputs = [] |
There was a problem hiding this comment.
the first list should not be necessary.
There was a problem hiding this comment.
Agreed, but I wrote it that way for stylistic consistency with the NIX_LDFLAGS definition further down. I could get rid of it anyway, should I?
Mindavi
added
the
6.topic: cross-compilation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows cross-compiling it.
Motivation for this change
Would not cross-compile beforehand.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)