Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

csvkit: 0.9.1 -> 1.0.2 #25404

Merged
merged 20 commits into from
May 5, 2017
Merged

csvkit: 0.9.1 -> 1.0.2 #25404

merged 20 commits into from
May 5, 2017

Conversation

vrthra
Copy link
Member

@vrthra vrthra commented May 1, 2017

Motivation for this change

Upgrade csvkit so that we can remove dateutil old versions (see #25375).
In order to upgrade csvkit, we need to update the following packages too

agate -> 1.6.0
agate-dbf -> 0.2.0
agate-excel -> 0.2.1
agate-sql -> 0.5.2 (new)
dbf -> 0.96.8
python-slugify -> 1.2.4

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@vrthra, thanks for your PR! By analyzing the history of the files in this pull request, we identified @FRidh to be a potential reviewer.

@FRidh
Copy link
Member

FRidh commented May 2, 2017

One commit per package please.

@FRidh FRidh self-assigned this May 2, 2017
@vrthra vrthra changed the title WIP: csvkit: 0.9.1 -> 1.0.2 csvkit: 0.9.1 -> 1.0.2 May 3, 2017
@FRidh
Copy link
Member

FRidh commented May 3, 2017

Can you enable the sandbox and test whether the packages are working?

@vrthra vrthra force-pushed the csvkit branch 2 times, most recently from bbc8726 to 8883b06 Compare May 3, 2017 18:55
@vrthra
Copy link
Member Author

vrthra commented May 3, 2017

@FRidh I have verified using the sandbox.

@FRidh FRidh merged commit 9652e3e into NixOS:master May 5, 2017
@FRidh
Copy link
Member

FRidh commented May 5, 2017

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants