Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #25723: Remove old GNU libstdc++ for qtbase #25769

Merged
merged 1 commit into from
May 14, 2017

Conversation

periklis
Copy link
Contributor

Motivation for this change

Fix for issue #25723

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@mention-bot
Copy link

@periklis, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ttuegel, @bjornfor and @copumpkin to be potential reviewers.

@periklis
Copy link
Contributor Author

cc @copumpkin

@periklis periklis force-pushed the topic_fix_qt58_qtbase_stl branch from 0f9c71a to 096c008 Compare May 14, 2017 07:46
@LnL7 LnL7 added the 6.topic: darwin Running or building packages on Darwin label May 14, 2017
@LnL7
Copy link
Member

LnL7 commented May 14, 2017

These still fail for me, but I'm pretty sure that was the case before.

pkgs.qt5.full.x86_64-darwin
pkgs.qt5.qtscript.x86_64-darwin
pkgs.qt5.qttools.x86_64-darwin
pkgs.qt5.qttranslations.x86_64-darwin
pkgs.qt5.qtwebengine.x86_64-darwin
pkgs.qt5.qtwebkit.x86_64-darwin

@LnL7 LnL7 merged commit 22b7b49 into NixOS:master May 14, 2017
@periklis
Copy link
Contributor Author

periklis commented May 14, 2017

@LnL7 This was the case for qtwebkit and qtwebengine only. I'll have a look.

@periklis
Copy link
Contributor Author

@LnL7 Are you sure that qttools, qttranslations, qtscript don't build correctly? My nix-build runs work perfectly.

@LnL7
Copy link
Member

LnL7 commented May 14, 2017

Oh you're right, some of the builds timed out.

@LnL7
Copy link
Member

LnL7 commented May 14, 2017

Yep, now it's just those two.

@periklis
Copy link
Contributor Author

They have been failing previously, too.

@periklis periklis deleted the topic_fix_qt58_qtbase_stl branch July 25, 2018 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: darwin Running or building packages on Darwin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants