Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checkbashisms: fixup #25773

Merged
merged 2 commits into from
May 14, 2017
Merged

checkbashisms: fixup #25773

merged 2 commits into from
May 14, 2017

Conversation

matthewbauer
Copy link
Member

@matthewbauer matthewbauer commented May 14, 2017

  • adds version to name
  • also adds "unix" as platform (anything with perl should work)
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

- adds version to name
- also adds "unix" as platform (anything with perl should work)
@mention-bot
Copy link

@matthewbauer, thanks for your PR! By analyzing the history of the files in this pull request, we identified @dezgeg and @lsix to be potential reviewers.

@Mic92 Mic92 merged commit 4b06293 into NixOS:master May 14, 2017
@Mic92
Copy link
Member

Mic92 commented May 14, 2017

Also this version might be better maintained: https://anonscm.debian.org/cgit/collab-maint/devscripts.git/tree/scripts/checkbashisms.pl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants