xapian: fixup darwin #25774
Merged
xapian: fixup darwin #25774
+7
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The configure script is detecting that __exp10 is available even though it isn’t on latest versions. This is the best fix I can find for now.
|
@matthewbauer, thanks for your PR! By analyzing the history of the files in this pull request, we identified @Mic92, @peterhoeg and @chaoflow to be potential reviewers. |
|
Is that with clang or gcc? |
Mic92
reviewed
May 14, 2017
| # but it’s not available on my systems (or hydra apparently) | ||
| postConfigure = stdenv.lib.optionalString stdenv.isDarwin '' | ||
| substituteInPlace config.h \ | ||
| --replace "#define HAVE___EXP10 1" "#undef HAVE___EXP10" |
There was a problem hiding this comment.
This seems a GNU extension (glibc).
There was a problem hiding this comment.
"exp10" is a glibc extension, but *BSD usually provide "__exp10":
http://www.manpagez.com/man/3/__exp10/
I don't know why it's broken on macOS now, but this seems to fix it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The configure script is detecting that __exp10 is available even
though it isn’t on latest versions. This is the best fix I can find
for now.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)