Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ecm-tools: init at github master #25768

Closed
wants to merge 1 commit into from
Closed

ecm-tools: init at github master #25768

wants to merge 1 commit into from

Conversation

m3tti
Copy link

@m3tti m3tti commented May 13, 2017 •
edited

Motivation for this change
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

FRidh
FRidh reviewed May 15, 2017
View reviewed changes
pkgs/applications/misc/ecm-tools/default.nix
{ stdenv, fetchgit }:
stdenv.mkDerivation rec {
name = "ecm-tools";
version = "master";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name should consists of a name part and a version part. Please see the Nixpkgs manual on the naming guidelines.

Copy link
Author

@m3tti m3tti May 15, 2017 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi the current maintainer doesn't have any version number. should i just go for 1.0?
the application was written back in 2002

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See https://github.com/alucryd/ecm-tools/releases/tag/v1.0.3

@matthewbauer
Copy link
Member

@GrahamcOfBorg build ecm-tools

matthewbauer
matthewbauer requested changes Apr 21, 2018
View reviewed changes
Copy link
Member

@matthewbauer matthewbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need release tag

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: ecm-tools

Partial log (click to expand)

install -m 755 bin2ecm /nix/store/w05rn9jhkyrhp6iqm8k89fy0r2vjc46v-ecm-tools/bin/
ln -s bin2ecm /nix/store/w05rn9jhkyrhp6iqm8k89fy0r2vjc46v-ecm-tools/bin/ecm2bin
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/w05rn9jhkyrhp6iqm8k89fy0r2vjc46v-ecm-tools
shrinking /nix/store/w05rn9jhkyrhp6iqm8k89fy0r2vjc46v-ecm-tools/bin/bin2ecm
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/w05rn9jhkyrhp6iqm8k89fy0r2vjc46v-ecm-tools/bin
patching script interpreter paths in /nix/store/w05rn9jhkyrhp6iqm8k89fy0r2vjc46v-ecm-tools
checking for references to /build in /nix/store/w05rn9jhkyrhp6iqm8k89fy0r2vjc46v-ecm-tools...
/nix/store/w05rn9jhkyrhp6iqm8k89fy0r2vjc46v-ecm-tools

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: ecm-tools

Partial log (click to expand)

install -m 755 bin2ecm /nix/store/abm2yz42ls8vlhgpvp52iqayg5nmbvq2-ecm-tools/bin/
ln -s bin2ecm /nix/store/abm2yz42ls8vlhgpvp52iqayg5nmbvq2-ecm-tools/bin/ecm2bin
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/abm2yz42ls8vlhgpvp52iqayg5nmbvq2-ecm-tools
shrinking /nix/store/abm2yz42ls8vlhgpvp52iqayg5nmbvq2-ecm-tools/bin/bin2ecm
strip is /nix/store/j7d4mr0ikv974ig7yzhknpsq288js4bs-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/abm2yz42ls8vlhgpvp52iqayg5nmbvq2-ecm-tools/bin
patching script interpreter paths in /nix/store/abm2yz42ls8vlhgpvp52iqayg5nmbvq2-ecm-tools
checking for references to /build in /nix/store/abm2yz42ls8vlhgpvp52iqayg5nmbvq2-ecm-tools...
/nix/store/abm2yz42ls8vlhgpvp52iqayg5nmbvq2-ecm-tools

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: ecm-tools

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@c0bw3b
Copy link
Contributor

c0bw3b commented Oct 14, 2018

Stalled for more than a year.

@c0bw3b c0bw3b closed this Oct 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joachifm joachifm joachifm left review comments

@FRidh FRidh FRidh left review comments

@matthewbauer matthewbauer matthewbauer requested changes

Assignees
No one assigned
Labels
8.has: package (new)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@m3tti @matthewbauer @GrahamcOfBorg @c0bw3b @joachifm @FRidh @pSub