Use the Renderer in the plugin and interface #1374
Merged
+354
−467
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
retest this please |
eggrobin
reviewed
May 15, 2017
ksp_plugin/renderer.hpp
Outdated
| not_null<std::unique_ptr<NavigationFrame>> plotting_frame); | ||
|
|
||
| // Returns the current plotting frame. This may not be the last set by | ||
| // |SetPlottingFrame| if it was overridden by a target vessel. |
There was a problem hiding this comment.
if it is overridden by a target vessel.
ksp_plugin/renderer.hpp
Outdated
| not_null<Celestial const*> celestial, | ||
| not_null<Ephemeris<Barycentric> const*> const ephemeris); | ||
|
|
||
| // Reverts to the previously active plotting frame. The second version only |
There was a problem hiding this comment.
to the frame last set by |SetPlottingFrame|.
eggrobin
reviewed
May 16, 2017
| auto parameters = target_->vessel->prediction_adaptive_step_parameters(); | ||
| parameters.set_max_steps(begin.trajectory()->Size()); | ||
| target_->vessel->set_prediction_adaptive_step_parameters(parameters); | ||
| target_->vessel->UpdatePrediction(current_time_ + prediction_length_); |
There was a problem hiding this comment.
This UpdatePrediction disappeared; it was an ugly hack, but removing it is probably a bug.
This was referenced May 19, 2017
pleroy
changed the title
eggrobin
approved these changes
May 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.