Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nodePackages.lumo-cljs: init at 1.5.0 #25770

Closed
wants to merge 1 commit into from
Closed

nodePackages.lumo-cljs: init at 1.5.0 #25770

wants to merge 1 commit into from

Conversation

m3tti
Copy link

@m3tti m3tti commented May 13, 2017

Motivation for this change
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@pSub
Copy link
Member

pSub commented May 14, 2017

You're sure you need all those changes (+4,435 −3,436) to add that package? I tried to view those large diffs on github but they failed to load due to their size.

@m3tti
Copy link
Author

m3tti commented May 14, 2017

I've just followed the README.md file in the nodePackages section. Primarily i've just added lumo-cljs into the node-packages.json file and run generate.sh which than created the other files (updated them v4 and v6).

@pSub
Copy link
Member

pSub commented May 15, 2017

Ok, then someone with more knowledge about node in nixpkgs should look into this.

@svanderburg
Copy link
Member

The churn of node package updates is always quite big. This is unfortunate side effect comes from node2nix trying to remain as compatible with npm. node2nix, for example, deploys an entire package + dependencies as a single derivation.

Also, the package set is always updated as a whole, meaning that also dependencies of other packages will be updated.

Although I know this is not desirable, this is something we have to "live" with" at the moment.

I noticed that the travis CI job is failing, but seems to be caused by a Haskell package.

From my perspective, since the tool is end-user software and the expressions are properly regenerated, this update can go in.

@Mic92
Copy link
Member

Mic92 commented Nov 9, 2018

Is there still interest in this package? I could add it in #50003

@Mic92
Copy link
Member

Mic92 commented Nov 14, 2018

If there is still an interest, just open a new pull request.

@Mic92 Mic92 closed this Nov 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants