planner: 20170429 -> split (into three versions) #25771
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@amiloradovsky, thanks for your PR! By analyzing the history of the files in this pull request, we identified @rasendubi and @aske to be potential reviewers. |
Provide several versions of the package, trade-off preferences: - stable: the official stable release, based on the tarball - unstable: the official Git repository, very conservative - unofficial: including few more of the proposed patches and enabling few more of the available features
joachifm
reviewed
Oct 20, 2017
|
|
||
| enableParallelBuilding = true; | ||
| let | ||
| callPackage = newScope stdenv; |
There was a problem hiding this comment.
Is there a specific reason for using this over the simpler import ./foo.nix { inherit stdenv; ... }?
|
Looks like https://gitlab.com/amiloradovsky/planner/commit/23699814d5cc425b89baa20236a802f28dca7c2c has been merged upstream, so unofficial is no longer needed. It does not make much sense sense to publish ancient stable versions, I would just bump the |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide several versions of the package, trade-off preferences:
and enabling few more of the available features
Motivation for this change
Provide more choice.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)