diary: init at 0.3 #25783
Closed
diary: init at 0.3 #25783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pSub
requested changes
May 15, 2017
|
|
||
| buildInputs = [ ncurses readline ]; | ||
|
|
||
| installPhase = '' |
There was a problem hiding this comment.
Please move the creation of the directories into preInstalledPhase and pass PREFIX=$out via installFlags.
| description = "Simple CLI diary"; | ||
| license = stdenv.lib.licenses.mit; | ||
| maintainers = [ stdenv.lib.maintainers.matthiasbeyer ]; | ||
| platforms = with stdenv.lib.platforms; linux; |
There was a problem hiding this comment.
You don't need with in that case, it will just increase runtime.
|
@pSub have a look at the last commit, that does not work... I tried |
|
@matthiasbeyer you want |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)