hardware: add enableRedistributalFirmware #25636
Merged
+51
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
added
the
6.topic: nixos
Mic92
commented
May 9, 2017
| assertion = !cfg.enableAllFirmware || (config.nixpkgs.config.allowUnfree or false); | ||
| message = '' | ||
| the list of hardware.enableAllFirmware contains non-redistributable licensed firmware files. | ||
| This requires nixpkgs.config.allowUnfree to be true. |
There was a problem hiding this comment.
This indentation is intentional for nice multi-line bullet points.
7 tasks
Profpatsch
reviewed
May 9, 2017
| ''; | ||
| }; | ||
|
|
||
| hardware.enableAllRedistributalFirmware = mkOption { |
There was a problem hiding this comment.
I’d change the name to RedistributableFirmware.
| default = false; | ||
| type = types.bool; | ||
| description = '' | ||
| Turn on this option if you want to enable all the firmware with a license allowing redistribution. |
There was a problem hiding this comment.
… (i.e. free firmware and <literal>firmware-linux-nonfree</literal>)
Mic92
changed the title
Due the recent inclusion of broadcom-bt-firmware in enableAllFirmware, it was required to set `nixpkgs.config.allowUnfree` to obtain the full list. To make this dependency more explicit an assertion is added and an alternative option `enableRedistributalFirmware` is provided to only obtain firmware with an license allowing redistribution.
|
Minor gripe: Spelling I think you meant Redistributable not Redistributal (which AFAICT is not a word) |
|
fixed in e697585. |
|
Well, that was one of my two comments, which apparently went unnoticed. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Due the recent inclusion of broadcom-bt-firmware in enableAllFirmware,
it was required to set
nixpkgs.config.allowUnfreeto obtain the fulllist. To make this dependency more explicit an assertion is added and an
alternative option
enableRedistributalFirmwareis provided to onlyobtain firmware with an license allowing redistribution.
see #25567 for previous discussion.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)