Skip to content

flashplayer: 25.0.0.148 -> 25.0.0.171 #25644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 9, 2017

Conversation

taku0
Copy link
Contributor

@taku0 taku0 commented May 9, 2017

Motivation for this change

(Release notes are not updated yet).

https://helpx.adobe.com/flash-player/release-note/fp_25_air_25_release_notes.html
https://helpx.adobe.com/security/products/flash-player.html

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)

  • Built on platform(s)

    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"

  • Tested execution of all binary files (usually in ./result/bin/)

  • Fits CONTRIBUTING.md.

  • Built packages

    • nix-env -i -f . -A pkgs.flashplayer
    • nix-build -I nixpkgs=. -A pkgsi686Linux.flashplayer
    • nix-build -I nixpkgs=. -E "(import <nixpkgs> {}).flashplayer.override { debug = true; }"
    • nix-build -I nixpkgs=. -E "(import <nixpkgs> {}).pkgsi686Linux.flashplayer.override { debug = true; }"
    • nix-build -I nixpkgs=. -A pkgs.flashplayer-standalone
    • nix-build -I nixpkgs=. -A pkgs.flashplayer-standalone-debugger
    • nix-build -I nixpkgs=. -E "(import <nixpkgs> {}).chromium.override { enablePepperFlash = true; }"
  • Played a video with Firefox (x86_64)

  • Played a video with Chromium (x86_64)

  • Checked the version with Firefox (x86_64) http://www.adobe.com/software/flash/about/

  • Played a flash animation with sound with flashplayer-standalone and flashplayer-standalone-debugger (x86_64)


Sorry, something went wrong.

@edolstra edolstra merged commit 00712bf into NixOS:master May 9, 2017
@edolstra
Copy link
Member

edolstra commented May 9, 2017

Thanks for upgrading all Flash packages!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants