Skip to content

chromedriver: Update and make available for linux-i686 and darwin #25797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 20, 2017

Conversation

selaux
Copy link
Contributor

@selaux selaux commented May 15, 2017

Motivation for this change
  • Chromedriver was outdated
  • Chromedriver is available on all systems so it can be packaged for all systems as well
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@mention-bot
Copy link

@selaux, thanks for your PR! By analyzing the history of the files in this pull request, we identified @cillianderoiste, @aske and @josthkko to be potential reviewers.

@selaux selaux changed the title Update chromedriver and make it available for linux-i686 and darwin chromedriver: Update and make available for linux-i686 and darwin May 15, 2017
@Mic92 Mic92 force-pushed the ubiquitous-chromedriver branch from 5da67bd to 357f193 Compare May 20, 2017 13:16
@Mic92 Mic92 merged commit c66af84 into NixOS:master May 20, 2017
@Mic92
Copy link
Member

Mic92 commented May 20, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants