Don't crash when translating untranslated strings #2765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kwpolska
reviewed
May 15, 2017
| if lang not in self: | ||
| LOGGER.warning('Unknown language %s', lang) | ||
| elif key not in self[lang]: | ||
| LOGGER.warning('Unknown message %s', key) |
There was a problem hiding this comment.
Is this enough to fix it? Perhaps you should add some fallback?
|
This breaks spectacularly and generates 161 error messages for the demo site (from post meta failing to be found). Reverting this. |
|
Fixing this right is hard, since functionaries are used for post metadata, post data, and messages. But I’d argue this is too rare to bother fixing anyway. The original issue was using v6 themes, which are already pretty incompatible, and v7.0.0 was released almost exactly 3 years ago. |
|
Ok, sorry about that :-P I could do a subclass that is only for messages and use that only in that place. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
keturn just reported on IRC that an old theme crashed because it used
messages['Posted']instead of the currentmessages['Posted:']... that's harsh :-)