Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.elasticsearch: 1.9.0 -> 2.4.1 #25786

Closed
wants to merge 1 commit into from

Conversation

nlewo
Copy link
Member

@nlewo nlewo commented May 14, 2017

Since the latest version of pythonPackages.pyelasticsearch requires
pythonPackages.elasticsearch < 2, we preserve the old version.

Motivation for this change
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Since the latest version of pythonPackages.pyelasticsearch requires
pythonPackages.elasticsearch < 2, we preserve the old version.
@mention-bot
Copy link

@nlewo, thanks for your PR! By analyzing the history of the files in this pull request, we identified @FRidh to be a potential reviewer.

@nlewo
Copy link
Member Author

nlewo commented May 14, 2017

Dependency of #25752.

@FRidh
Copy link
Member

FRidh commented May 15, 2017

Since the latest version of pythonPackages.pyelasticsearch requires
pythonPackages.elasticsearch < 2, we preserve the old version.

The last pyelasticsearch update we got is one and a half year ago and the package is hardly seeing any maintenance, so I think its better to just remove the expression.

@dtulig , you originally added the expression.

@FRidh
Copy link
Member

FRidh commented May 15, 2017

If you're updating a whole stack of packages that belong together, then please bundle them as separate commits in a single PR.

@dtulig
Copy link
Contributor

dtulig commented May 15, 2017

One consideration to keep in mind before removing it is the python elastic search library tracks the elastic search versions. It would be reasonable to keep the latest pyelasticsearch_1, pyelasticsearch_2, pyelasticsearch_5 available, with a default, pyelasticsearch, on the most recent stable elasticsearch version (in this case, that appears to be 5) or the primary nixpkgs supported elasticsearch (perhaps 2.x?). Nixpkgs has elasticsearch for 1.x and elasticsearch2 for 2.x.

That said, I'm not attached to keeping 1.x around so if others feel strongly about keeping a single version I'm ok with that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants