re-raise the original exception, not a copy of it #2764

evgeni · 2017-05-14T19:52:57Z

Pull Request Checklist

I’ve read the guidelines for contributing.
I updated AUTHORS.txt and CHANGES.txt (if the change is non-trivial) and documentation (if applicable).
I tested my changes.

Description

otherwise the resulting traceback will have the raise line as the offending one, not the really problematic one.

example:

>>> try:
...     import nothing
... except ImportError as e:
...     raise e
Traceback (most recent call last):
  File "<input>", line 5, in <module>
    raise e
ImportError: No module named nothing

>>> try:
...     import nothing
... except ImportError as e:
...     raise
Traceback (most recent call last):
  File "<input>", line 2, in <module>
    import nothing
ImportError: No module named nothing

otherwise the resulting traceback will have the `raise` line as the offending one, not the really problematic one. example: >>> try: ... import nothing ... except ImportError as e: ... raise e Traceback (most recent call last): File "<input>", line 5, in <module> raise e ImportError: No module named nothing >>> try: ... import nothing ... except ImportError as e: ... raise Traceback (most recent call last): File "<input>", line 2, in <module> import nothing ImportError: No module named nothing

ralsina

Thanks for the fix!

evgeni force-pushed the raise branch from 17e7606 to 60a86ff Compare May 14, 2017 19:59

ralsina approved these changes May 14, 2017

View reviewed changes

ralsina merged commit 119ca73 into getnikola:master May 14, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

re-raise the original exception, not a copy of it #2764

re-raise the original exception, not a copy of it #2764

evgeni commented May 14, 2017 •

edited

ralsina left a comment

re-raise the original exception, not a copy of it #2764

re-raise the original exception, not a copy of it #2764

Conversation

evgeni commented May 14, 2017 • edited

Pull Request Checklist

Description

ralsina left a comment

Choose a reason for hiding this comment

evgeni commented May 14, 2017 •

edited