barony: init at 2.0.5 #25432
Closed
barony: init at 2.0.5 #25432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why is the patch so large? |
|
Because it touches all the places where the game loads data files, which is all over the code. I've PRed the changes upstream, and they got accepted then reverted again because of some merging issues — they should be in the next release though and I'll remove the patch from the package once that happens. |
|
@lheckemann do you think we should keep this PR open? |
|
Since upstream has now integrated my patch to allow setting a custom data dir, this can be made significantly smaller. However, not sure it should be integrated at all — it's got a fairly limited audience (just me, AFAIK) and I'm not sure additional stuff to maintain is what nixpkgs really needs… |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Fun game.
While the engine is GPLv3, the game requires proprietary data to run. The path to this data can be specified with the
-datadir=path/to/dataoption, or it can be run from the directory containing the data.Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
./result/bin/)