Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fetchdarcs: add SSL_CERT_FILE environment variable (master) #25250

Merged
merged 1 commit into from Apr 26, 2017
Merged

fetchdarcs: add SSL_CERT_FILE environment variable (master) #25250

merged 1 commit into from Apr 26, 2017

Conversation

k0001
Copy link
Contributor

@k0001 k0001 commented Apr 26, 2017 •
edited

Motivation for this change

Fetching from darcs repositories through HTTPS fails without this change, since CA certificates are not made available to darcs. Example:

building path(s) '/nix/store/kcas73q9cs3107kkl6z5wrcg0sr3i3r1-fetchdarcs'
getting http://hub.darcs.net/RyanGlScott/vector-algorithms   into /nix/store/kcas73q9cs3107kkl6z5wrcg0sr3i3r1-fetchdarcs
Identifying repository http://hub.darcs.net/RyanGlScott/vector-algorithms

darcs failed:  Not a repository: http://hub.darcs.net/RyanGlScott/vector-algorithms (Peer certificate cannot be authenticated with given CA certificates)

HINT: Do you have the right URI for the repository?

builder for '/nix/store/l0s2vhr69ikg2r0i1ya3z98jxvr2f6dc-fetchdarcs.drv' failed with exit code 2
error: build of '/nix/store/l0s2vhr69ikg2r0i1ya3z98jxvr2f6dc-fetchdarcs.drv' failed
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

cc @shlevy @luite

@mention-bot
Copy link

@k0001, thanks for your PR! By analyzing the history of the files in this pull request, we identified @kosmikus, @globin and @bennofs to be potential reviewers.

@k0001 k0001 mentioned this pull request Apr 26, 2017
Merged
@luite
Copy link

luite commented Apr 26, 2017

This fixes the problem for me on Linux (Ubuntu 16.04), nixpkgs 17.03

@shlevy shlevy merged commit d3bf2af into NixOS:master Apr 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: fetch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@k0001 @mention-bot @luite @shlevy @lukateras