generic Haskell builder: Don't call stack setup.
#25254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`stack setup` should not be called inside `nix-build` because that makes stack download a GHC instead of using nix's one (the one provided `generic-stack-builder.nix` as the `ghc` argument), which will not work. Further evidence for this is that the `stack --nix` support intentionally uses `--system-ghc` for the same purpose.
|
@nh2, thanks for your PR! By analyzing the history of the files in this pull request, we identified @mboes, @YPares and @domenkozar to be potential reviewers. |
|
@peti lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stack setupshould not be called insidenix-buildbecausethat makes stack download a GHC instead of using nix's one
(the one provided
generic-stack-builder.nixas theghcargument),which will not work.
Further evidence for this is that the
stack --nixsupportintentionally uses
--system-ghcfor the same purpose.This change was developed in cooperation with @mboes who made the nix-stack integration
Motivation for this change
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)