pythonPackages.phpserialize: init at 1.3 #25521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FRidh
requested changes
May 5, 2017
pkgs/top-level/python-packages.nix
Outdated
| @@ -8833,6 +8833,27 @@ in { | |||
| }; | |||
| }; | |||
|
|
|||
| phpserialize = buildPythonPackage rec { | |||
There was a problem hiding this comment.
check header of this file, this file needs to be moved
There was a problem hiding this comment.
Ok. Just to make sure: I need to move this definition into pkgs/development/python-modules/phpserialize/default.nix and then use callPackage in pkgs/top-level/python-packages.nix?
There are a lot of other Python libraries defined in this file. Are those just some historical remains?
There was a problem hiding this comment.
they will be moved eventually (on update for instance).
|
I moved the package definition to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
phpserializeis a dependency of another Python package of which I'll make a separate pull request.Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)I also ran the unit tests which are available at the project's github repo in a nix-shell launched with
nix-shell -p python35Packages.phpserialize --pure.