Adding some Jane Street packages at version 0.9 (in progress) #25534
Conversation
|
The new builder seems fine, but rather than just upgrading everything either all at once, or piecemeal, what I'd suggest doing instead is temporarily making I don't think sexplib is one of the culprits, but istr there being some api breakage on the 113->0.9 transition. tl;dr |
|
P.S., can someone who has that power retrigger the OSX build? It appears to have failed during the installing nix stage, which I'm 99% sure wasn't this change, but OCaml + OSX tends to have surprising failures so it'd be good to see whether it works. |
|
@maurer Thanks for your comment. After some thinking, I reached the same conclusion. Let me add a few other 0.9 packages to this PR so as to confirm that the new builder works fine for all of them. |
Zimmi48
changed the title
|
@vbgl Just found out while adding package |
Zimmi48
force-pushed
the
sexplib-0.9
branch
2 times, most recently
from
57b3b02
to
44c5c30
Compare
|
My |
|
Actually, my new version does not work either ( |
|
OK fixed. This was because I was using |
Zimmi48
force-pushed
the
sexplib-0.9
branch
3 times, most recently
from
970d12b
to
0d49e0c
Compare
A more recent 0.9.1 version exists, but the last version of bin_prot (0.9.0) won't build with it.
A more recent 0.9.1 version exists but it fails to compile with this expression.
|
My approach here does not scale. Here is a better proposal: #25658 |
This pull request is mostly to get comments from OCaml packages (especially Jane Street packages) maintainers.
It seems that Nixpkgs contains lots of Jane Street packages at version 113.33.03.
Recently they have been moving to 0.9 with (it seems) quite a few differences in the way those are compiled / installed.
I need a few of these packages at version 0.9+, among them sexplib.
I have created the builder
newBuildOcamlJaneto generically build any of those packages. I'd appreciate feedback on that.I've also added a package for sexplib version 0.9.1: at first I just wanted to replace version 113.33.03 with version 0.9.1 but a lot of packages depend on it, so it implies updating many many packages. Also some of the new versions of these packages have new dependencies, so it requires adding new packages as well. I am ready to do it, but I'd like feedback before.
Do you mind the new builder and does it seem OK to you? I probably could have modified the current builder to check if the version is before or after v0.9 but that would have been more complex and would have created unnecessary dependencies.
Do you confirm that updating all those packages (at once) is the way to go?
cc @maurer @ericbmerritt @vbgl