nodePackages: split into v4/v6 package set #25528
Merged
+6,254
−40,605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
A full package set is not needed for both node versions. The goal is to remove the large amount of generated files. Instead only packages which might be needed in v4 development environments are added to a dedicated node-packages-v4.json file.
|
Possibly related to #23259 as well. |
|
Or maybe not related to #23259 because neither of your PRs seem to have touched the |
|
I will work on removing all references to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
A full package set is not needed for both node versions. The goal is to
remove the large amount of generated files. Instead only packages which
might be needed in v4 development environments are added to a dedicated
node-packages-v4.json file.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)