virtmanager: disable openstack support by default #25481
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@FRidh, thanks for your PR! By analyzing the history of the files in this pull request, we identified @fpletz, @offlinehacker and @qknight to be potential reviewers. |
|
I'm really not familiar with virtmanager but this got it working. It might make sense to group dependencies by feature. |
FRidh
commented
May 3, 2017
| sed -i "/'install_egg_info'/d" setup.py | ||
| '' + optionalString openstackSupport '' | ||
| sed -i 's|/usr/share/libvirt/cpu_map.xml|${system-libvirt}/share/libvirt/cpu_map.xml|g' virtinst/capabilities.py |
There was a problem hiding this comment.
don't know if this is correct, but since virtinst was mentioned...
FRidh
requested review from
fpletz,
DamienCassou,
qknight and
offlinehacker
and removed request for
DamienCassou
|
@volth if virtinst works without glanceclient then that's an even better solution. Just make sure you keep a commit per package you touch. |
|
That was my impression of virtmanager as well. I think those two expressions should be reviewed, checking which build inputs are really needed. In any case, feel free to open a PR to replace this one. |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
os-testr was marked as broken [1] because of a pbr bump [2].
virtmanager depends indirectly on os-testr, however, both dependencies
using os-testr are optional. Therefore, we disable them by default to
maintain a working virtmanager.
[1] 52b1995
[2] 6eac5fd
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)cc @volth @qknight @offlinehacker @fpletz