Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

red: init at 0.6.3 #28147

Merged
merged 1 commit into from Aug 16, 2017
Merged

red: init at 0.6.3 #28147

merged 1 commit into from Aug 16, 2017

Conversation

uralbash
Copy link
Member

Motivation for this change
Things done

Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers.

  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Aug 11, 2017

fails to build with the following error on Linux:

patching sources
configuring
no configure script, doing nothing
building
releases/rebol-core/
releases/rebol-core/rebol
releases/rebol-core/about.txt
/nix/store/xa5a2jlryx7mwadpxg0zgn83rpf66qxy-stdenv/setup: line 985: ./rebol/releases/rebol-core/rebol: No such file or directory
builder for _/nix/store/nw5b4nmsndyxkcs5iwvvkbdm0fj14w1k-red-0.6.3.drv_ failed with exit code 127
error: build of _/nix/store/nw5b4nmsndyxkcs5iwvvkbdm0fj14w1k-red-0.6.3.drv_ failed
/home/joerg/.nix-profile/bin/nix-shell: failed to build all dependencies

@uralbash
Copy link
Member Author

@Mic92 fixed

FRidh
FRidh reviewed Aug 13, 2017
View reviewed changes
pkgs/development/interpreters/red/default.nix Outdated
name = "red-${version}";
version = "0.6.3";
src = fetchFromGitHub {
rev = "6a43c767fa2e85d668b83f749158a18e62c30f70";
Copy link
Member

@FRidh FRidh Aug 13, 2017 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not "v${version}"?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FRidh added "v"

@Mic92
Copy link
Member

Mic92 commented Aug 16, 2017

Please remove the prefix /usr. Otherwise bin will not be in the $PATH of the user and
the command red cannot be reached:

$ find /nix/store/f7d4ggkjyb06fspd9kaj7q854ssm317j-red-v0.6.3/usr/
/nix/store/f7d4ggkjyb06fspd9kaj7q854ssm317j-red-v0.6.3/usr/
/nix/store/f7d4ggkjyb06fspd9kaj7q854ssm317j-red-v0.6.3/usr/bin
/nix/store/f7d4ggkjyb06fspd9kaj7q854ssm317j-red-v0.6.3/usr/bin/red
/nix/store/f7d4ggkjyb06fspd9kaj7q854ssm317j-red-v0.6.3/usr/share
/nix/store/f7d4ggkjyb06fspd9kaj7q854ssm317j-red-v0.6.3/usr/share/licenses
/nix/store/f7d4ggkjyb06fspd9kaj7q854ssm317j-red-v0.6.3/usr/share/licenses/red-v0.6.3
/nix/store/f7d4ggkjyb06fspd9kaj7q854ssm317j-red-v0.6.3/usr/share/licenses/red-v0.6.3/BSL-License.txt
/nix/store/f7d4ggkjyb06fspd9kaj7q854ssm317j-red-v0.6.3/usr/share/licenses/red-v0.6.3/BSD-3-License.txt
/nix/store/f7d4ggkjyb06fspd9kaj7q854ssm317j-red-v0.6.3/usr/share/doc
/nix/store/f7d4ggkjyb06fspd9kaj7q854ssm317j-red-v0.6.3/usr/share/doc/red-v0.6.3
/nix/store/f7d4ggkjyb06fspd9kaj7q854ssm317j-red-v0.6.3/usr/share/doc/red-v0.6.3/red-system-specs.html
/nix/store/f7d4ggkjyb06fspd9kaj7q854ssm317j-red-v0.6.3/usr/share/doc/red-v0.6.3/red-system-quick-test.html

@uralbash
Copy link
Member Author

@Mic92 Moved everything to bin directory

@Mic92 Mic92 merged commit dc282c1 into NixOS:master Aug 16, 2017
@Mic92
Copy link
Member

Mic92 commented Aug 16, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@uralbash @Mic92 @teh @FRidh